Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 25 include_all to include on match #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clairmont32
Copy link

Include_all.xml had onmatch="exclude". Changed this due to the filename stating its intention

Include_all.xml had onmatch="exclude". Changed this due to the filename stating its intention
@ipfyx
Copy link

ipfyx commented Apr 23, 2024

Your fix is incorrect. In sysmon :

  • If you want every possible event (i.e include_all.xml), you set a match on "exclude" with no rule. Nothing can match, therefore nothing is excluded, therefore everything is included.
      <ProcessTampering onmatch="exclude">
      </ProcessTampering>
  • If you don't want any event (i.e exclude_all.xml), you set a match on "exclude" with no rule. Nothing can match, therefore nothing is included, therefore everything is excluded.
      <ProcessTampering onmatch="include">
      </ProcessTampering>

Got it ?

The file from the repo is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants